Ticket #55 (closed defect: fixed)

Opened 4 months ago

Last modified 2 months ago

Neighbour versus neighbor

Reported by: bsouthey Assigned to: matthieu.brucher
Priority: major Milestone:
Component: learn Version:
Keywords: Cc:

Description

What spelling variant should be used?

There is a mixture of British and USA spelling that causes a build failure. Most of the source uses 'neighbor' (269 lines) but the build and regression use 'neighbour' (31 lines).

building 'scikits.learn.machine.manifold_learning.regression.neighbours._neighbours' extension
compiling C++ sources
C compiler: g++ -pthread -fno-strict-aliasing -DNDEBUG -O2 -fmessage-length=0 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -g -fPIC

compile options: '-Iscikits/learn/machine/manifold_learning -I/usr/lib64/python2.5/site-packages/numpy/core/include -I/usr/include/python2.5 -c'
g++: neighbours/neighbours.cpp
g++: neighbours/neighbours.cpp: No such file or directory
g++: no input files
g++: neighbours/neighbours.cpp: No such file or directory
g++: no input files
error: Command "g++ -pthread -fno-strict-aliasing -DNDEBUG -O2 -fmessage-length=0 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -g -fPIC -Iscikits/learn/machine/manifold_learning -I/usr/lib64/python2.5/site-packages/numpy/core/include -I/usr/include/python2.5 -c neighbours/neighbours.cpp -o build/temp.linux-x86_64-2.5/neighbours/neighbours.o" failed with exit status 1

Change History

(in reply to: ↑ description ) 04/21/08 11:44:53 changed by bsouthey

The fix is to change the spelling in these two files:

scikits/learn/machine/manifold_learning/regression/setup.py
scikits/learn/machine/manifold_learning/regression/PLMR.py

06/25/08 09:51:11 changed by matthieu.brucher

  • status changed from new to assigned.
  • owner changed from cdavid to matthieu.brucher.

06/25/08 09:51:29 changed by matthieu.brucher

  • status changed from assigned to closed.
  • resolution set to fixed.

Should be fixed in the SVN now.